Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for SBP property #272

Merged
merged 2 commits into from
Jun 16, 2024
Merged

Conversation

JoshuaLampert
Copy link
Contributor

I added some tests for the SBP property as discussed in #268 (review).

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.08%. Comparing base (f09cbac) to head (bca68a5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   90.97%   91.08%   +0.11%     
==========================================
  Files          35       35              
  Lines        5262     5263       +1     
==========================================
+ Hits         4787     4794       +7     
+ Misses        475      469       -6     
Flag Coverage Δ
unittests 91.08% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranocha ranocha enabled auto-merge (squash) June 16, 2024 12:32
@ranocha ranocha disabled auto-merge June 16, 2024 13:03
@ranocha ranocha merged commit 5402b15 into ranocha:main Jun 16, 2024
19 of 20 checks passed
@JoshuaLampert JoshuaLampert deleted the test-SBP-property branch June 16, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants