Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RAPIDS repos for RMM pool and detail API improvements #10

Closed
4 tasks done
harrism opened this issue Jan 11, 2024 · 1 comment
Closed
4 tasks done

Update RAPIDS repos for RMM pool and detail API improvements #10

harrism opened this issue Jan 11, 2024 · 1 comment
Assignees
Labels
improvement Improves an existing functionality

Comments

@harrism
Copy link
Member

harrism commented Jan 11, 2024

rapidsai/rmm#1417 and a followon PR makes a number of improvements and changes to help consumers of RMM avoid accessing RMM's detail namespace.

  • initial pool size in pool_memory_resource is required to be provided (no longer optional)
  • rmm::detail::available_device_memory() (moving to `rmm::available_device_memory())
  • Move alignment utility functions out of detail namespace.
  • Add utility to calculate an aligned percentage of free device memory in bytes. This way, existing instantiations of pool_memory_resource<Upstream>(upstream) can be replaced by pool_memory_resource<Upstream>(upstream, rmm::percent_of_free_device_memory(50), which matches previous behavior.

All RAPIDS repos that use any of the above will need to be updated. rapidsai/rmm#1417 only adds functionality. A follow on PR(s) will deprecate / remove functionality after RAPIDS repos are updated. Based on a search, the following repo issues cover the required changes.

@harrism harrism self-assigned this Jan 11, 2024
@harrism harrism added the improvement Improves an existing functionality label Jan 11, 2024
@harrism
Copy link
Member Author

harrism commented Jan 17, 2024

Finished.

@harrism harrism closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant