Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Update RAFT to always explicitly specify RMM pool size #2087

Closed
Tracked by #10
harrism opened this issue Jan 11, 2024 · 0 comments · Fixed by #2088
Closed
Tracked by #10

[BUG] Update RAFT to always explicitly specify RMM pool size #2087

harrism opened this issue Jan 11, 2024 · 0 comments · Fixed by #2088
Labels
bug Something isn't working

Comments

@harrism
Copy link
Member

harrism commented Jan 11, 2024

rapidsai/rmm#1417 and followon PRs make a number of improvements and changes to help consumers of RMM avoid accessing RMM's detail namespace.

  • initial pool size in pool_memory_resource is required to be provided (no longer optional)
  • rmm::detail::available_device_memory() (moving to `rmm::available_device_memory())
  • Move alignment utility functions out of detail namespace.
  • Add utility to calculate an aligned percentage of free device memory in bytes. This way, existing instantiations of pool_memory_resource<Upstream>(upstream) can be replaced by pool_memory_resource<Upstream>(upstream, rmm::percent_of_free_device_memory(50), which matches previous behavior.

RAFT should be updated for these changes once rapidsai/rmm#1417 is merged. I have a PR ready to open.
@harrism harrism added the bug Something isn't working label Jan 11, 2024
This was referenced Jan 11, 2024
Merged
Closed
rapids-bot bot pushed a commit that referenced this issue Jan 17, 2024
@harrism
Provide explicit pool size for pool_memory_resources and clean up inc…
dbc33ea 
…ludes (#2088)

This PR fixes up RAFT to avoid usage that will soon be deprecated in RMM.

Depends on rapidsai/rmm#1417

Fixes #2087

Authors:
  - Mark Harris (https://github.com/harrism)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #2088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide explicit pool size for pool_memory_resources and clean up includes harrism/raft
1 participant
@harrism