Skip to content

Commit

Permalink
Replace column comparison utilities functions with macros (#11007)
Browse files Browse the repository at this point in the history
Replaced macros provide the line of failure in the test code file which the functions can not provide.

Authors:
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #11007
  • Loading branch information
karthikeyann authored Jun 1, 2022
1 parent fae2221 commit 5367858
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions cpp/docs/TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -411,12 +411,12 @@ auto struct_col {struct_column_wrapper.release()};
A common operation in testing is verifying that two columns are equal, or equivalent, or that they
have the same metadata.

#### `expect_column_properties_equal`
#### `CUDF_TEST_EXPECT_COLUMN_PROPERTIES_EQUAL`

Verifies that two columns have the same type, size, and nullability. For nested types, recursively
verifies the equality of type, size and nullability of all nested children.

#### `expect_column_properties_equivalent`
#### `CUDF_TEST_EXPECT_COLUMN_PROPERTIES_EQUIVALENT`

Verifies that two columns have equivalent type and equal size, ignoring nullability. For nested
types, recursively verifies the equivalence of type, and equality of size of all nested children,
Expand All @@ -428,17 +428,17 @@ different scales. Nested type columns can be equivalent in the case where they b
but one has children (also empty) and the other does not. For columns with nonzero size, both equals
and equivalent expect equal number of children.

#### `expect_columns_equal`
#### `CUDF_TEST_EXPECT_COLUMNS_EQUAL`

Verifies that two columns have equal properties and verifies elementwise equality of the column
data. Null elements are treated as equal.

#### `expect_columns_equivalent`
#### `CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT`

Verifies that two columns have equivalent properties and verifies elementwise equivalence of the
column data. Null elements are treated as equivalent.

#### `expect_equal_buffers`
#### `CUDF_TEST_EXPECT_EQUAL_BUFFERS`

Verifies the bitwise equality of two device memory buffers.

Expand Down

0 comments on commit 5367858

Please sign in to comment.