Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add set_allocator to cuDF Python documentation (or deprecate in favor of rmm.reinitialize) #11097

Closed
beckernick opened this issue Jun 13, 2022 · 1 comment · Fixed by #11958
Closed

[DOC] Add set_allocator to cuDF Python documentation (or deprecate in favor of rmm.reinitialize) #11097

beckernick opened this issue Jun 13, 2022 · 1 comment · Fixed by #11958
Labels
doc Documentation good first issue Good for newcomers Python Affects Python cuDF API.

Comments

@beckernick
Copy link
Member

set_allocator enables users to set the GPU allocator and configure RMM. It's a wrapper around rmm.reinitialize.

We should either add this to the documentation or deprecate it in favor of users directly using rmm.reinitialize. Searching for set_allocator in the docs returns no results.
@beckernick beckernick added doc Documentation Python Affects Python cuDF API. good first issue Good for newcomers labels Jun 13, 2022
@shwina
Copy link
Contributor

shwina commented Jun 13, 2022

cudf.set_allocator is a wrapper around rmm.reinitialize and I think we should deprecate it in favor of the latter:

  • It brings more visibility to RMM, which is good to know about if you are using RAPIDS and care about memory management/performance.
  • In code that uses cuDF in combination with other RAPIDS libraries (e.g, cuml), using cudf.set_allocator() will implicitly configure memory management for other libraries as well, which feels smelly to me compared to using rmm.reinitialize() to configure memory management explicitly for all of RAPIDS.

@vyasr vyasr mentioned this issue Oct 20, 2022
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Oct 28, 2022
@vyasr
Add deprecation warning for set_allocator. (#11958)
c915523 
Resolves #11097.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: #11958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Documentation good first issue Good for newcomers Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deprecation warning for set_allocator. vyasr/cudf
2 participants
@shwina @beckernick