Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Remove JNI map_lookup #11212

Closed
mythrocks opened this issue Jul 6, 2022 · 1 comment
Closed

[BUG] Remove JNI map_lookup #11212

mythrocks opened this issue Jul 6, 2022 · 1 comment
Assignees
@mythrocks
Labels
bug Something isn't working

Comments

@mythrocks
Copy link
Contributor

After the introduction of maps_column_view in #10380, the kernels in map_lookup.cu should no longer be required. Those were hurriedly knocked together written to support only map<string, string>. The JNI code should currently be re-routing through maps_column_view.

It would be good to remove this cruft to avoid confusion and clutter.
@mythrocks mythrocks added bug Something isn't working Needs Triage Need team to review and classify labels Jul 6, 2022
@mythrocks mythrocks self-assigned this Jul 6, 2022
@mythrocks mythrocks added code quality and removed Needs Triage Need team to review and classify labels Jul 6, 2022
@mythrocks
Copy link
Contributor Author

Addressed with #11221.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mythrocks mythrocks

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mythrocks