Remove cruft in map_lookup #11221
Merged
Remove cruft in map_lookup #11221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unused code in map_lookup.cu and map_lookup.hpp. rapidsai#10380 replaced the functionality provided in map_lookup.*, and expanded map-lookup support to all value types, and string/integral key types. The old map_lookup kernels were retained "just in case". Removing the old kernels should reduce confusion, and avoid clutter.
mythrocks
added
code quality
Spark
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11221 +/- ##
===============================================
Coverage ? 86.30%
===============================================
Files ? 144
Lines ? 22698
Branches ? 0
===============================================
Hits ? 19589
Misses ? 3109
Partials ? 0 Continue to review full report at Codecov.
|
ttnghia
approved these changes
Jul 8, 2022
revans2
approved these changes
Jul 8, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unused code in
map_lookup.cuandmap_lookup.hpp.#10380 replaced the functionality provided in
map_lookup.*, and expandedmap-lookup support to all value types, and string/integral key types.
The old map_lookup kernels were retained "just in case".
Removing the old kernels should reduce confusion, and avoid clutter.