Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Random data generator creates incorrect sequences of decimal elements #11850

Closed
vuule opened this issue Oct 3, 2022 · 0 comments · Fixed by #11863
Closed

[BUG] Random data generator creates incorrect sequences of decimal elements #11850

vuule opened this issue Oct 3, 2022 · 0 comments · Fixed by #11863
Assignees
@karthikeyann
Labels
bug Something isn't working cuIO cuIO issue tests Unit testing for project

Comments

@vuule
Copy link
Contributor

vuule commented Oct 3, 2022

The random data generator creates sequences with given run length. The run length looks correct for non-decimal types. Decimal element sequences zig-zag between valid(?) values and small values, regardless of run length.

The zig-zag sequence do seem to correlate to the run length.

image2
image (1)

One possible root cause would be incorrect data width for decimal types, so every other element picks up the high bits of the wide value.
@vuule vuule added bug Something isn't working tests Unit testing for project cuIO cuIO issue labels Oct 3, 2022
@karthikeyann karthikeyann self-assigned this Oct 4, 2022
@karthikeyann karthikeyann mentioned this issue Oct 5, 2022
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Oct 6, 2022
@karthikeyann
Fix decimal benchmark input data generation (#11863)
1ef722d 
closes #11850
Fixes decimal benchmark input data generation.
Generated data alternated between two values because `device_uvector<T>` has both value and scale. scale is fixed for a column and hence when this data is copied to `cudf::column`, this column values alternated between values and scale.
Fix is to use `device_storage_type_t<T>` instead of `T`.

Authors:
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Nghia Truong (https://github.com/ttnghia)
  - David Wendt (https://github.com/davidwendt)

URL: #11863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karthikeyann karthikeyann

Labels
bug Something isn't working cuIO cuIO issue tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix decimal benchmark input data generation karthikeyann/cudf
2 participants
@karthikeyann @vuule