Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code comments to deprecations that depend on upstream pandas changes #13619

Closed
bdice opened this issue Jun 26, 2023 · 0 comments · Fixed by #13710
Closed

Add code comments to deprecations that depend on upstream pandas changes #13619

bdice opened this issue Jun 26, 2023 · 0 comments · Fixed by #13710
Assignees
@galipremsagar
Labels
Python Affects Python cuDF API.

Comments

@bdice
Copy link
Contributor

bdice commented Jun 26, 2023

Some deprecations in cudf are issuing a FutureWarning that is intended to match pandas behavior. These deprecations are not safe to remove until some (potentially future) pandas removal. This deviates from the current Developer Guide, which says:

cuDF follows the policy of deprecating code for one release prior to removal. For example, if we decide to remove an API during the 22.08 release cycle, it will be marked as deprecated in the 22.08 release and removed in the 22.10 release.

We should annotate any warnings that are meant to be kept with a code comment like # Do not remove until pandas removes this. so that developers can differentiate deprecated code paths that are safe to remove from those that are expected to be maintained.

We should also update the developer guide with this new guidance with a policy for pandas API deprecations that we have to preserve.
@bdice bdice added the Python Affects Python cuDF API. label Jun 26, 2023
@galipremsagar galipremsagar mentioned this issue Jul 17, 2023
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this issue Jul 17, 2023
@galipremsagar
Enforce deprecations and add clarifications around existing deprecati…
494535e 
…ons (#13710)

Fixes: #13619
This PR enforces deprecation warnings and adds comments around the existing deprecation warnings that shouldn't be dropped right now.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Matthew Roeschke (https://github.com/mroeschke)

URL: #13710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce deprecations and add clarifications around existing deprecations galipremsagar/cudf
2 participants
@bdice @galipremsagar