Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA][JNI] Throw specific exception from Table.readJSON instead of AssertionError #14331

Open
andygrove opened this issue Oct 25, 2023 · 0 comments
Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@andygrove
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Per the discussion at NVIDIA/spark-rapids#9304 (comment), the Spark plugin currently has to parse the error message from an AssertionError, which is an anti-pattern. This happens when the plugin calls Table.readJSON where the input is not JSON format.

This exception is thrown in the constructor for Table:

  public Table(long[] cudfColumns) {
    assert cudfColumns != null && cudfColumns.length > 0 : "CudfColumns can't be null or empty";

Describe the solution you'd like
We should throw a specific exception instead.

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added feature request New feature or request Needs Triage Need team to review and classify Spark Functionality that helps Spark RAPIDS labels Oct 25, 2023
@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue and removed Needs Triage Need team to review and classify labels Nov 9, 2023
@GregoryKimball GregoryKimball added this to the Nested JSON reader milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
Status: In Progress
Development

No branches or pull requests

2 participants