Specify recoverWithNull when reading JSON files #9304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <andygrove@nvidia.com>
andygrove
changed the title
|
build |
jlowe
approved these changes
Oct 25, 2023
| try { | ||
| Table.readJSON(cudfSchema, jsonOpts, dataBuffer, 0, dataSize) | ||
| } catch { | ||
| case e: AssertionError if e.getMessage == "CudfColumns can't be null or empty" => |
There was a problem hiding this comment.
Parsing exception messages is an anti-pattern. Would be nice to have a followup to get a more specific exception type to help distinguish this case.
There was a problem hiding this comment.
I agree, probably would be better to do this for all Exceptions and AssertionErrors.
There was a problem hiding this comment.
Thanks. I filed rapidsai/cudf#14331
sameerz
added
the
task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9326
Closes #9310
Depends on rapidsai/cudf#14279
This PR enables the new cuDF option
recoverWithNulls(see rapidsai/cudf#12532) when reading from JSON files.