Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace device_memory_resource* with device_async_resource_ref #15498

Closed
Tracked by #16
, #1443
...
harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #15507
Closed
Tracked by #16
, #1443
...

Replace device_memory_resource* with device_async_resource_ref #15498

harrism opened this issue Apr 10, 2024 · 0 comments · Fixed by #15507
Labels
improvement Improvement / enhancement to an existing function

Comments

@harrism
Copy link
Member

harrism commented Apr 10, 2024

Update occurences of rmm::mr::device_memory_resource* to
rmm::device_async_resource_ref in this repo. The rationale is explained
in this document.
@harrism harrism added the improvement Improvement / enhancement to an existing function label Apr 10, 2024
This was referenced Apr 10, 2024
Closed
Merged
rapids-bot bot pushed a commit that referenced this issue Apr 17, 2024
@harrism
Convert libcudf resource parameters to rmm::device_async_resource_ref (…
9192d25 
…#15507)

Closes #15498

For reviewers:
Almost all of the thousands of changes are simple textual replace of `rmm::mr::device_memory_resource *` with `rmm::device_async_resource_ref`. 

I think the only substantial changes that are different are in `contiguous_split.cu` (which was assigning `nullptr` to the MR pointer -- I have changed these cases to use a `std::optional<rmm::device_async_resource_ref>`), and in JNI code.

~I still need to figure out how to build and test the JNI bindings. And figure out necessary Cython changes.~

JNI is passing CI now. Cython required no changes.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Jason Lowe (https://github.com/jlowe)
  - Bradley Dice (https://github.com/bdice)

URL: #15507
@bdice bdice mentioned this issue Apr 18, 2024
Merged
3 tasks
This was referenced Apr 23, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
1 participant
@harrism