Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] RangeIndex must be materialized in parquet writer when index=True in parquet writer #6873

Closed
galipremsagar opened this issue Dec 1, 2020 · 1 comment · Fixed by #7711
Closed

[FEA] RangeIndex must be materialized in parquet writer when index=True in parquet writer #6873

galipremsagar opened this issue Dec 1, 2020 · 1 comment · Fixed by #7711
Assignees
@galipremsagar
Labels
bug Something isn't working cuIO cuIO issue Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Describe the FEA
When index=True/None parquet writer currently only writes RangeIndex attributes to metadata. Instead when index=True we must match pandas behaviour in parquet writer where the RangeIndex is materialized into a column.

Additional context
pandas-dev/pandas#37896 (comment)
@galipremsagar galipremsagar added feature request New feature or request Python Affects Python cuDF API. labels Dec 1, 2020
@galipremsagar galipremsagar self-assigned this Dec 1, 2020
@galipremsagar galipremsagar changed the title [FEA] RangeIndex must be materialized in parquet writer when index=True [FEA] RangeIndex must be materialized in parquet writer when index=True in parquet writer Dec 1, 2020
@galipremsagar galipremsagar added the cuIO cuIO issue label Dec 1, 2020
@galipremsagar galipremsagar mentioned this issue Dec 1, 2020
Merged
4 tasks
@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@github-actions github-actions bot added the stale label Feb 16, 2021
@galipremsagar galipremsagar mentioned this issue Mar 24, 2021
Merged
@kkraus14 kkraus14 added bug Something isn't working and removed feature request New feature or request labels Mar 24, 2021
rapids-bot bot pushed a commit that referenced this issue Mar 24, 2021
@galipremsagar
Materialize RangeIndex when index=True in parquet writer (#7711)
1417297 
Resolves: #6873 

This PR enables support to materialize a `RangeIndex` when `index=True`. Didn't add any tests as we already test for this in `test_parquet_index` but we were having the tests wrong due to a typo which was writing to the same file both pandas & cudf dataframes. This test is now fixed in this PR.

Authors:
  - GALI PREM SAGAR (@galipremsagar)

Approvers:
  - Keith Kraus (@kkraus14)

URL: #7711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working cuIO cuIO issue Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Materialize RangeIndex when index=True in parquet writer galipremsagar/cudf
2 participants
@kkraus14 @galipremsagar