Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support interleave_columns for lists of lists and lists of structs #9106

Closed
ttnghia opened this issue Aug 24, 2021 · 0 comments · Fixed by #9130
Closed

[FEA] Support interleave_columns for lists of lists and lists of structs #9106

ttnghia opened this issue Aug 24, 2021 · 0 comments · Fixed by #9130
Assignees
@ttnghia
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS

Comments

@ttnghia
Copy link
Contributor

ttnghia commented Aug 24, 2021

Recently the interleave_columns API has been added support for structs columns. However, it still only supports lists columns with non-nested row entries. In order to support arbitrary nested levels for structs, we also need to add support for lists of lists and lists of structs.
@ttnghia ttnghia added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Aug 24, 2021
@ttnghia ttnghia self-assigned this Aug 24, 2021
@ttnghia ttnghia mentioned this issue Aug 26, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #9130 Sep 2, 2021
rapids-bot bot pushed a commit that referenced this issue Sep 2, 2021
@ttnghia
Implement interleave_columns for lists with arbitrary nested type (#…
4556b5b 
…9130)

This PR adds more support for lists column in the `interleave_column` API. In particular, it adds nested types support for the list entries. As such, now we can call `interleave_column` on a lists column of any type such as lists of structs, lists of lists, lists of lists of lists and so on. In addition, this PR also does a simple refactor of the existing overload functions with a new style of SFINAE implementation.

Closes #9106.

Authors:
  - Nghia Truong (https://github.com/ttnghia)

Approvers:
  - MithunR (https://github.com/mythrocks)
  - https://github.com/nvdbaranec

URL: #9130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ttnghia ttnghia

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement interleave_columns for lists with arbitrary nested type ttnghia/cudf
1 participant
@ttnghia