Fix null check when comparing structs in arg_min operation of reduction/groupby
#10026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
bug
ttnghia
changed the title
arg_min operation of reduction/groupbyarg_min operation of reduction/groupby
|
@res-life Please test this PR if it can fix all your issues. If there is another corner case that fails, let report it here so I can address all together. It is not good to have a separate PR to address one issue at a time. If you test it only when it has been merged, then report new issues and pause, you will end up to wait => fix => wait.... forever. |
This comment has been minimized.
This comment has been minimized.
hyperbolic2346
approved these changes
Jan 12, 2022
|
Test case passed with this code, please merge. |
|
Thanks the reviewers. Hope that we will not have another related bug 😄 |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another fix for NVIDIA/spark-rapids#4434, when the null order is wrongly handled if the input structs column does not have nulls at the top level but only has null at the children levels.