Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for appending decimal128 under list and struct types #10105

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Jan 21, 2022

I know that this is past the freeze date. This is a fix for a P1 bug that we just found when trying to build Scalar values of Lists and Structs that contain Decimal128 values. We might be able to work around it some other way, but it would take a lot of changes to the existing Spark plugin code to do that so I wanted to try this first.

@revans2 revans2 added bug Something isn't working 3 - Ready for Review Ready for review by team Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jan 21, 2022
@revans2 revans2 self-assigned this Jan 21, 2022
@revans2 revans2 requested a review from a team as a code owner January 21, 2022 17:30
@github-actions github-actions bot added the Java Affects Java cuDF API. label Jan 21, 2022
@razajafri
Copy link
Contributor

@kuhushukla is such a champ!

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #10105 (4480692) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 4480692 differs from pull request most recent head 816ec62. Consider uploading reports for the commit 816ec62 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02   #10105      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20607     +302     
================================================
+ Hits               2130     2148      +18     
- Misses            18175    18459     +284     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.66% <0.00%> (-0.25%) ⬇️
python/dask_cudf/dask_cudf/core.py 70.85% <0.00%> (-0.17%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dtypes.py 0.00% <0.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a0f59...816ec62. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants