Add JNI for strings::split_re and strings::split_record_re
#10139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
feature request
|
Don't you need java side changes and java tests as well here? Typically Java bindings and JNI bindings go hand in hand. This is in draft mode so I guess you might have it brewing on your branch still but wanted to put this out just in case. |
Sure, I'll add. This is still draft WIP :) |
This comment has been minimized.
This comment has been minimized.
# Conflicts: # cpp/include/cudf/strings/split/split_re.hpp
github-actions
bot
removed
conda
libcudf
ttnghia
added
3 - Ready for Review
revans2
approved these changes
Feb 11, 2022
revans2
approved these changes
Feb 11, 2022
andygrove
approved these changes
Feb 12, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Java binding for the new strings API
strings::split_reandstrings::split_record_re, which allows splitting strings by regular expression delimiters.In addition, the Java string split overloads with default split pattern (an empty string) are removed in this PR. That is because with default empty pattern the Java's split API produces different results than cudf.
Finally, some cleanup has been perform automatically thanks to IntelliJ IDE.
Depends on #10128.
This is breaking change which is fixed by NVIDIA/spark-rapids#4714. Thus, it should be merged at the same time with NVIDIA/spark-rapids#4714.