Replace custom cached_property implementation with functools
#10272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
added
tech debt
non-breaking
brandon-b-miller
approved these changes
Feb 11, 2022
shwina
commented
Feb 11, 2022
python/cudf/cudf/core/frame.py
Outdated
| @@ -91,7 +91,7 @@ def _num_rows(self) -> int: | |||
|
|
|||
| @property | |||
| def _column_names(self) -> List[Any]: # TODO: List[str]? | |||
| return self._data.names | |||
| return list(self._data.names) | |||
There was a problem hiding this comment.
We previously returned a tuple while hinting that we were returning a list. Which one should we return?
There was a problem hiding this comment.
bdice
reviewed
Feb 11, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10272 +/- ##
================================================
+ Coverage 10.42% 10.67% +0.25%
================================================
Files 119 122 +3
Lines 20603 20866 +263
================================================
+ Hits 2148 2228 +80
- Misses 18455 18638 +183
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces our custom
cached_propertywith that provided byfunctoolssince Python 3.8. This uncovered a couple of typing bugs that previously eluded us.