Fix incorrect slicing of GDS read/write calls #10274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f max slice size; add tests
vuule
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10274 +/- ##
================================================
+ Coverage 10.42% 10.67% +0.24%
================================================
Files 119 122 +3
Lines 20603 20873 +270
================================================
+ Hits 2148 2228 +80
- Misses 18455 18645 +190
Continue to review full report at Codecov.
|
|
rerun tests |
hyperbolic2346
approved these changes
Feb 14, 2022
devavret
approved these changes
Feb 14, 2022
| std::vector<file_io_slice> slices; | ||
| slices.reserve(n_slices); | ||
| std::generate_n(std::back_inserter(slices), n_slices, [&, idx = 0]() mutable { | ||
| auto const slice_offset = idx++ * max_slice_size; |
There was a problem hiding this comment.
TIL the value you change in a lambda will stick.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue happens when the read/write size is a multiple of the maximum slice size. It this case, size of the last slice is computed as
0, instead ofmax_slice_size:(t == n_slices - 1) ? size % max_slice_bytes : max_slice_bytesThis PR reimplements this part of code and adds unit tests.