Refactor array function #10364
Merged
Refactor array function #10364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…much as possible and remove remaining cruft.
vyasr
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10364 +/- ##
================================================
+ Coverage 10.42% 10.64% +0.21%
================================================
Files 119 126 +7
Lines 20603 20938 +335
================================================
+ Hits 2148 2228 +80
- Misses 18455 18710 +255
Continue to review full report at Codecov.
|
bdice
requested changes
Feb 26, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the implementation of
__array_function__forSeriesandDataFrameto bring them further into alignment. It also inlines a number of functions defined inutils/utils.pythat were previously used only inSeries.__array_ufunc__, building on the improvements in #10217, #10287, and #10346 to clear out methods related to the old__array_ufunc__dispatch that are now only used by this__array_function__implementation. Inlining these methods also allows significant simplification since they were handling cases that are no longer relevant or possible. Unlike those previous PRs, this one does not actually enable any new features. Although it should marginally accelerate array functions by simplifying the dispatch logic, the fact that this API makes few promises about the nature of the function being applied and our desire to have it "just work" as much as possible means that we must simply adopt an EAFP approach and returnNotImplementedif any part of the process fails.