Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable read_text with dask_cudf using byte_range #10407

Merged
merged 6 commits into from
Mar 22, 2022

Conversation

ChrisJar
Copy link
Contributor

This uses the byte_range argument added to read_text with #10150 to create a dask version of read_text

@ChrisJar ChrisJar requested a review from a team as a code owner March 10, 2022 01:52
@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 10, 2022
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #10407 (4859623) into branch-22.04 (a7d88cd) will increase coverage by 75.75%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           branch-22.04   #10407       +/-   ##
=================================================
+ Coverage         10.42%   86.17%   +75.75%     
=================================================
  Files               119      141       +22     
  Lines             20603    22501     +1898     
=================================================
+ Hits               2148    19391    +17243     
+ Misses            18455     3110    -15345     
Impacted Files Coverage Δ
...ython/custreamz/custreamz/tests/test_dataframes.py 99.39% <0.00%> (-0.01%) ⬇️
python/custreamz/custreamz/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/__init__.py 82.35% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/udf/pipeline.py
python/dask_cudf/dask_cudf/io/tests/test_text.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/udf/utils.py 98.63% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/tests/test_reductions.py 100.00% <0.00%> (ø)
... and 110 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f2e10...4859623. Read the comment docs.

@ChrisJar ChrisJar requested a review from rjzamora March 15, 2022 15:44
@quasiben
Copy link
Member

Looks really good @ChrisJar . Can you also add a test which uses the new byte_range parameter ?

@quasiben quasiben added non-breaking Non-breaking change feature request New feature or request labels Mar 21, 2022
@quasiben
Copy link
Member

Thanks @ChrisJar

@quasiben
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4300ba4 into rapidsai:branch-22.04 Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants