JNI support for Collect Ops in Reduction #10427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
sperlingxx
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #10427 +/- ##
================================================
+ Coverage 86.13% 86.15% +0.01%
================================================
Files 139 139
Lines 22460 22438 -22
================================================
- Hits 19347 19332 -15
+ Misses 3113 3106 -7
Continue to review full report at Codecov.
|
jlowe
approved these changes
Mar 14, 2022
| } | ||
|
|
||
| /** | ||
| * Merge the partial sets produced by multiple CollectSetAggregations. Each null/nan value will be regarded as |
There was a problem hiding this comment.
Suggested change
| * Merge the partial sets produced by multiple CollectSetAggregations. Each null/nan value will be regarded as | |
| * Merge the partial sets produced by multiple CollectSetAggregations. Each null/NaN value will be regarded as |
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes public APIs for collect operations as
ReductionAggregation, which are essential to spark-rapids. In addition, this PR also extends the test framework of Reduction to discriminate output types from input types.