Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lists of Columns for Various Files #10463

Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 19, 2022

This PR covers many low hanging fruits for #10153. All API accepting Frames now accepts a list of columns in the following files:

  • hash.pyx
  • interop.pyx
  • join.pyx
  • partitioning.pyx
  • quantiles.pyx
  • reshape.pyx
  • search.pyx
  • transform.pyx
  • lists.pyx
  • string/combine.pyx

This PR covers point 5 in the follow-ups to #9889.
Also, in join.pyx, gil was not released when dispatching workload to libcudf. This PR fixes that.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Mar 19, 2022
@isVoid isVoid added this to the CuDF Python Refactoring milestone Mar 19, 2022
@isVoid isVoid self-assigned this Mar 19, 2022
@vyasr
Copy link
Contributor

vyasr commented Mar 21, 2022

If this is still in draft maybe it should be targeting 22.06? Fine to leave it pointing at 22.04 for CI and to move it later though, just checking what you intend.

@isVoid
Copy link
Contributor Author

isVoid commented Mar 21, 2022

It's targeting 22.06

@vyasr
Copy link
Contributor

vyasr commented Mar 21, 2022

I'm guessing that you mean that you branched off of 22.06 locally? The actual PR is attempting to merge into 22.04.

@isVoid isVoid changed the base branch from branch-22.04 to branch-22.06 March 21, 2022 20:13
@isVoid isVoid marked this pull request as ready for review April 14, 2022 23:21
@isVoid isVoid requested a review from a team as a code owner April 14, 2022 23:21
@isVoid isVoid added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 14, 2022
python/cudf/cudf/_lib/interop.pyx Show resolved Hide resolved
python/cudf/cudf/_lib/interop.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/interop.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/interop.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/interop.pyx Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/indexed_frame.py Outdated Show resolved Hide resolved
isVoid and others added 4 commits April 18, 2022 16:36
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 18, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #10463 (906da01) into branch-22.06 (3c13ef1) will increase coverage by 0.06%.
The diff coverage is 93.16%.

@@               Coverage Diff                @@
##           branch-22.06   #10463      +/-   ##
================================================
+ Coverage         86.33%   86.40%   +0.06%     
================================================
  Files               140      142       +2     
  Lines             22289    22315      +26     
================================================
+ Hits              19244    19281      +37     
+ Misses             3045     3034      -11     
Impacted Files Coverage Δ
python/cudf/cudf/core/algorithms.py 90.47% <ø> (ø)
python/cudf/cudf/core/column/string.py 89.22% <ø> (+0.24%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.64% <ø> (+0.15%) ⬆️
python/cudf/cudf/core/index.py 92.31% <ø> (ø)
python/cudf/cudf/core/multiindex.py 92.14% <ø> (ø)
python/cudf/cudf/core/series.py 95.15% <ø> (-0.13%) ⬇️
python/cudf/cudf/utils/ioutils.py 79.60% <ø> (ø)
python/cudf/cudf/utils/utils.py 90.28% <ø> (ø)
python/cudf/cudf/core/frame.py 93.54% <72.22%> (-1.22%) ⬇️
python/dask_cudf/dask_cudf/tests/utils.py 90.90% <90.90%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c35d5...906da01. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 9dc728a into rapidsai:branch-22.06 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants