Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Series.applymap #10497

Merged
merged 9 commits into from
Mar 29, 2022
Merged

Deprecate Series.applymap #10497

merged 9 commits into from
Mar 29, 2022

Conversation

brandon-b-miller
Copy link
Contributor

Part of #10169

@brandon-b-miller brandon-b-miller added 2 - In Progress Currently a work in progress numba Numba issue Python Affects Python cuDF API. non-breaking Non-breaking change labels Mar 23, 2022
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner March 23, 2022 17:28
@brandon-b-miller brandon-b-miller self-assigned this Mar 23, 2022
@brandon-b-miller brandon-b-miller added the feature request New feature or request label Mar 23, 2022
bdice
bdice approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with two minor suggestions.

python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
brandon-b-miller and others added 2 commits March 23, 2022 13:03
@brandon-b-miller
copyrights
89cba8a
@brandon-b-miller @bdice
Apply suggestions from code review
e0d5203 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@brandon-b-miller
Copy link
Contributor Author

rerun tests

@brandon-b-miller brandon-b-miller changed the base branch from branch-22.04 to branch-22.06 March 24, 2022 20:41
@brandon-b-miller
Copy link
Contributor Author

rerun tests

1 similar comment
@brandon-b-miller
Copy link
Contributor Author

rerun tests

@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@90882d3). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06   #10497   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      140           
  Lines                   ?    22298           
  Branches                ?        0           
===============================================
  Hits                    ?    19253           
  Misses                  ?     3045           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90882d3...1b85370. Read the comment docs.

@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a0495f4 into rapidsai:branch-22.06 Mar 29, 2022
@bdice bdice mentioned this pull request Jun 2, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Aug 26, 2022
@bdice
Remove deprecated Series.applymap. (#11031)
48dc168 
This PR removes the deprecated `Series.applymap` function. This function does not exist in pandas. Users should switch to using `Series.apply`. (Note that `DataFrame.applymap` does exist in both pandas and cudf.) Deprecated in #10497.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - https://github.com/brandon-b-miller
  - Michael Wang (https://github.com/isVoid)

URL: #11031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@brandon-b-miller brandon-b-miller

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change numba Numba issue Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandon-b-miller @bdice