-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate index merging #10689
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-22.06
from
vyasr:refactor/deprecate_index_merge
Apr 26, 2022
Merged
Deprecate index merging #10689
rapids-bot
merged 5 commits into
rapidsai:branch-22.06
from
vyasr:refactor/deprecate_index_merge
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ef8213.
vyasr
added
3 - Ready for Review
Ready for review by team
Python
Affects Python cuDF API.
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10689 +/- ##
================================================
- Coverage 86.38% 86.38% -0.01%
================================================
Files 142 142
Lines 22334 22341 +7
================================================
+ Hits 19294 19300 +6
- Misses 3040 3041 +1
Continue to review full report at Codecov.
|
isVoid
reviewed
Apr 20, 2022
isVoid
approved these changes
Apr 26, 2022
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates support for merging Index objects. pandas only supports merging of DataFrames, so we should move towards that as well. The main internal implication of this change is that
BaseIndex.union
andBaseIndex.difference
now require an internal conversion to aDataFrame
followed by a conversion of the result back to the appropriate index type. Since the intermediate objects are not modified and don't involve additional memory allocations, this change just adds a little bit of Python overhead to index merging (10-50 us). Once the deprecated code is fully removed, though, we should be able to make this time back by simplifying the internals of joining, which currently has logic for handling Series and Index objects internally.