Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import NA from missing rather than using cudf.NA everywhere #10821

Merged

Conversation

brandon-b-miller
Copy link
Contributor

This PR changes cuDF so NA isn't used around the codebase from the top level cudf namespace and rather is imported directly from missing. This is part of #10820 and comes as a follow up to #10791 (comment)

@brandon-b-miller brandon-b-miller added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 10, 2022
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner May 10, 2022 16:28
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #10821 (dab2263) into branch-22.06 (8d861ce) will decrease coverage by 0.14%.
The diff coverage is 92.33%.

@@               Coverage Diff                @@
##           branch-22.06   #10821      +/-   ##
================================================
- Coverage         86.40%   86.26%   -0.15%     
================================================
  Files               143      144       +1     
  Lines             22448    22552     +104     
================================================
+ Hits              19396    19454      +58     
- Misses             3052     3098      +46     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 88.78% <ø> (-0.31%) ⬇️
python/cudf/cudf/core/frame.py 93.41% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 91.70% <ø> (ø)
python/cudf/cudf/testing/testing.py 81.81% <50.00%> (+0.12%) ⬆️
python/cudf/cudf/io/parquet.py 90.47% <83.69%> (-2.23%) ⬇️
python/cudf/cudf/core/index.py 92.06% <88.88%> (-0.25%) ⬇️
python/cudf/cudf/core/scalar.py 89.01% <90.90%> (-0.31%) ⬇️
python/cudf/cudf/core/dataframe.py 93.78% <96.36%> (+0.08%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (+0.22%) ⬆️
python/cudf/cudf/core/_compat.py 100.00% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c5bad...dab2263. Read the comment docs.

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 10, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 366206d into rapidsai:branch-22.06 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants