-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dask-cuDF cumulative groupby ops #10889
Merged
rapids-bot
merged 14 commits into
rapidsai:branch-22.08
from
brandon-b-miller:fea-daskcudf-cumsum-etc
Jul 27, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
26bff13
add tests
brandon-b-miller 5b92522
Merge branch 'branch-22.08' into fea-daskcudf-cumsum-etc
brandon-b-miller f9297e7
Merge branch 'branch-22.08' into fea-daskcudf-cumsum-etc
brandon-b-miller 346d0e8
Merge branch 'branch-22.08' into fea-daskcudf-cumsum-etc
brandon-b-miller 1c9e7bf
Merge branch 'branch-22.08' into fea-daskcudf-cumsum-etc
brandon-b-miller 12f3c17
working through bugs
brandon-b-miller 5eb5bb8
updates
brandon-b-miller 5fd707c
Merge branch 'branch-22.08' into fea-daskcudf-cumsum-etc
brandon-b-miller 20fa2d2
Merge branch 'branch-22.08' into fea-daskcudf-cumsum-etc
brandon-b-miller 10c6234
pass style checks
brandon-b-miller 034f13c
test series object as well
brandon-b-miller 2379a0a
Update python/dask_cudf/dask_cudf/tests/test_groupby.py
charlesbluca 096f5d9
xfail and point to dask
brandon-b-miller 9992e2e
Merge branch 'fea-daskcudf-cumsum-etc' of github.com:brandon-b-miller…
brandon-b-miller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky, but we might want to keep this as
SUPPORTED_AGGS
to make sure we don't eventually mess something up with support for new aggregations down the line:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, disregard this, I am forgetting that
_aggs_supported
really only needs to be tested for different groupby agg structures 😅 I think that a reasonable way to check that all aggregations are actually "supported" (i.e. use dask-cudf's groupby codepath) is to add the layer check I proposed in #10853