Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add support for Series.between #11051

Merged
merged 3 commits into from
Jun 6, 2022
Merged

[REVIEW] Add support for Series.between #11051

merged 3 commits into from
Jun 6, 2022

Conversation

galipremsagar
Copy link
Contributor

Resolves: #10443

This PR adds between API for Series. Here is the reference pandas API: https://pandas.pydata.org/docs/reference/api/pandas.Series.between.html

@galipremsagar galipremsagar added feature request New feature or request 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function labels Jun 3, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner June 3, 2022 22:22
@galipremsagar galipremsagar requested a review from bdice June 3, 2022 22:22
@galipremsagar galipremsagar self-assigned this Jun 3, 2022
@galipremsagar galipremsagar added non-breaking Non-breaking change and removed feature request New feature or request labels Jun 3, 2022
bdice
bdice requested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expand testing to validate more of the claimed behaviors of the docstring -- otherwise LGTM! Thank you for adding this feature so quickly to unblock downstream work. 😄

python/cudf/cudf/tests/test_series.py Show resolved Hide resolved
python/cudf/cudf/tests/test_series.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/series.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 4, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@4d7595f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11051   +/-   ##
===============================================
  Coverage                ?   86.34%           
===============================================
  Files                   ?      144           
  Lines                   ?    22723           
  Branches                ?        0           
===============================================
  Hits                    ?    19620           
  Misses                  ?     3103           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7595f...8a49ee7. Read the comment docs.

@galipremsagar galipremsagar requested a review from bdice June 6, 2022 17:52
bdice
bdice approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional tests are a good touch. Nice work @galipremsagar.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jun 6, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a187f44 into rapidsai:branch-22.08 Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Add .between() to create easier range based mapping
2 participants
@galipremsagar @bdice