Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take iterators by value in clamp.cu. #11084

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Take iterators by value in clamp.cu. #11084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8c4409
Take iterators by value.
bdice Jun 8, 2022
4d42a55
Merge remote-tracking branch 'upstream/branch-22.08' into iterator-by…
bdice Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions cpp/src/replace/clamp.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ std::pair<std::unique_ptr<column>, std::unique_ptr<column>> form_offsets_and_cha

template <typename OptionalScalarIterator, typename ReplaceScalarIterator>
std::unique_ptr<cudf::column> clamp_string_column(strings_column_view const& input,
OptionalScalarIterator const& lo_itr,
ReplaceScalarIterator const& lo_replace_itr,
OptionalScalarIterator const& hi_itr,
ReplaceScalarIterator const& hi_replace_itr,
OptionalScalarIterator lo_itr,
ReplaceScalarIterator lo_replace_itr,
OptionalScalarIterator hi_itr,
ReplaceScalarIterator hi_replace_itr,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
{
Expand Down Expand Up @@ -153,10 +153,10 @@ std::unique_ptr<cudf::column> clamp_string_column(strings_column_view const& inp
template <typename T, typename OptionalScalarIterator, typename ReplaceScalarIterator>
std::enable_if_t<cudf::is_fixed_width<T>(), std::unique_ptr<cudf::column>> clamper(
column_view const& input,
OptionalScalarIterator const& lo_itr,
ReplaceScalarIterator const& lo_replace_itr,
OptionalScalarIterator const& hi_itr,
ReplaceScalarIterator const& hi_replace_itr,
OptionalScalarIterator lo_itr,
ReplaceScalarIterator lo_replace_itr,
OptionalScalarIterator hi_itr,
ReplaceScalarIterator hi_replace_itr,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
{
Expand Down Expand Up @@ -200,10 +200,10 @@ std::enable_if_t<cudf::is_fixed_width<T>(), std::unique_ptr<cudf::column>> clamp
template <typename T, typename OptionalScalarIterator, typename ReplaceScalarIterator>
std::enable_if_t<std::is_same_v<T, string_view>, std::unique_ptr<cudf::column>> clamper(
column_view const& input,
OptionalScalarIterator const& lo_itr,
ReplaceScalarIterator const& lo_replace_itr,
OptionalScalarIterator const& hi_itr,
ReplaceScalarIterator const& hi_replace_itr,
OptionalScalarIterator lo_itr,
ReplaceScalarIterator lo_replace_itr,
OptionalScalarIterator hi_itr,
ReplaceScalarIterator hi_replace_itr,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
{
Expand All @@ -215,10 +215,10 @@ std::enable_if_t<std::is_same_v<T, string_view>, std::unique_ptr<cudf::column>>
template <typename T, typename OptionalScalarIterator, typename ReplaceScalarIterator>
std::unique_ptr<column> clamp(
column_view const& input,
OptionalScalarIterator const& lo_itr,
ReplaceScalarIterator const& lo_replace_itr,
OptionalScalarIterator const& hi_itr,
ReplaceScalarIterator const& hi_replace_itr,
OptionalScalarIterator lo_itr,
ReplaceScalarIterator lo_replace_itr,
OptionalScalarIterator hi_itr,
ReplaceScalarIterator hi_replace_itr,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr = rmm::mr::get_current_device_resource())
{
Expand Down