Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up _copy_type_metadata #11156

Merged
merged 10 commits into from
Jul 4, 2022
Merged

Clean up _copy_type_metadata #11156

merged 10 commits into from
Jul 4, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 27, 2022

This PR moves index-related logic from Frame._copy_type_metadata into the IndexedFrame override. It also removes all reference to the index parameter from the corresponding methods of various index types.

@vyasr vyasr added 3 - Ready for Review Ready for review by team code quality Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 27, 2022
@vyasr vyasr added this to the CuDF Python Refactoring milestone Jun 27, 2022
@vyasr vyasr requested a review from a team as a code owner June 27, 2022 22:55
@vyasr vyasr self-assigned this Jun 27, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@e45741f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11156   +/-   ##
===============================================
  Coverage                ?   86.32%           
===============================================
  Files                   ?      144           
  Lines                   ?    22742           
  Branches                ?        0           
===============================================
  Hits                    ?    19631           
  Misses                  ?     3111           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45741f...73d2ff0. Read the comment docs.

charlesbluca
charlesbluca reviewed Jun 28, 2022
View reviewed changes
python/cudf/cudf/core/index.py Show resolved Hide resolved
python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from charlesbluca June 29, 2022 20:42
@vyasr @charlesbluca
Update python/cudf/cudf/core/index.py
d5bf8f4 
Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com>
@vyasr @charlesbluca
Update python/cudf/cudf/core/index.py
73d2ff0 
Co-authored-by: Charles Blackmon-Luca <20627856+charlesbluca@users.noreply.github.com>
@vyasr
Copy link
Contributor Author

vyasr commented Jun 30, 2022

rerun tests

@vyasr
Copy link
Contributor Author

vyasr commented Jul 1, 2022

rerun tests

1 similar comment
@vyasr
Copy link
Contributor Author

vyasr commented Jul 4, 2022

rerun tests

@vyasr
Copy link
Contributor Author

vyasr commented Jul 4, 2022

@gpucibot merge

1 similar comment
@vyasr
Copy link
Contributor Author

vyasr commented Jul 4, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 41ce35f into rapidsai:branch-22.08 Jul 4, 2022
@vyasr vyasr deleted the refactor/copy_type_metadata branch July 4, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@charlesbluca charlesbluca charlesbluca approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
cuDF Python Refactoring
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @shwina @charlesbluca