Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully support nested types in lists::drop_list_duplicates #11224

Closed
wants to merge 31 commits into from
Closed

Fully support nested types in lists::drop_list_duplicates #11224

wants to merge 31 commits into from

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jul 8, 2022 •
edited
Loading

This reimplements lists::drop_list_duplicates, adding full support for nested types. The new implementation is significantly shorter than the old one by leveraging the existing label_segments and stable_distinct utilities APIs. Performance should also be improved significantly by completely avoiding sorting.

Closes #11093, closes #11053, and closes #9257.

Depends on:

Follow up work:

Progress:

  • Implementation.
  • Fix unit tests

@ttnghia
Add new implementation and test files
1d7e8e0
@ttnghia
Fix compile error
51b80db
@ttnghia
Rename function
08a76ad
@ttnghia
Implement cudf::detail::stable_distinct and lists::distinct
16101f7
@ttnghia
Rewrite doxygen
5ec13d6
@ttnghia
Rename variable
6c5b738
@ttnghia
Rewrite comment
5b70eee
@ttnghia
Rename files
238248d
@ttnghia
Implement float tests
ba6bf6b
@ttnghia
Implement string tests
3845c95
@ttnghia
Implement tests for ListDistinctTypedTest
507c82d
@ttnghia
Complete the remaining tests
2cb8347
@ttnghia
Merge branch 'branch-22.08' into add_lists_distinct
7efdea0
@ttnghia
Rewrite doxygen
4388637
@ttnghia
Misc
4dd5e74
@ttnghia
Misc
3b0760c
@ttnghia
Rewrite test
9730b70
@ttnghia
Fix doxygen
9bd9b6f
@ttnghia
Fix header
790a482
@ttnghia
Rewrite doxygen
1c58baa
@ttnghia
Rewrite doxygen and fix headers
d493c4f
@ttnghia
Fix iterator type
d090d2a
@ttnghia
Rewrite doxygen
ee51822
@ttnghia
Add empty lines
ccdd6f0
@ttnghia
Merge branch 'branch-22.08' into add_lists_distinct
034ee2a
@ttnghia
Update default stream
b1231a2
@ttnghia
Merge branch 'branch-22.08' into add_lists_distinct
af91b80
@ttnghia
Merge branch 'branch-22.08' into add_lists_distinct
86c9ba8
@ttnghia
Handle empty input
99d70b1
@ttnghia
Merge branch 'add_lists_distinct' into reimplement_drop_list_duplicates
c08b8d8
@ttnghia ttnghia added feature request New feature or request 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jul 8, 2022
@ttnghia ttnghia self-assigned this Jul 8, 2022
@github-actions github-actions bot added the CMake CMake build issue label Jul 8, 2022
@ttnghia ttnghia mentioned this pull request Jul 8, 2022
Closed
@ttnghia ttnghia closed this Jul 8, 2022
@ttnghia ttnghia deleted the reimplement_drop_list_duplicates branch July 14, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ttnghia ttnghia

Labels
2 - In Progress Currently a work in progress CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
1 participant
@ttnghia