-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lists::drop_list_duplicates
#11236
Remove lists::drop_list_duplicates
#11236
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11236 +/- ##
================================================
+ Coverage 86.34% 86.37% +0.03%
================================================
Files 144 144
Lines 22826 22826
================================================
+ Hits 19708 19715 +7
+ Misses 3118 3111 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CMake changes approved
Should the PR be named "Remove ..."? Deprecation means that the API is still available. |
lists::drop_list_duplicates
lists::drop_list_duplicates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. -1,741 lines of code is a great feeling.
@ttnghia I think this can be merged when you're ready. You're more familiar with the state of all the linked issues than I am -- please close or comment on all the related issues once this is merged. edit: Also, I fixed the labels -- PRs removing public APIs are always |
Thanks all for helping on this. I'm merging. |
@gpucibot merge |
This PR completely removes
cudf::lists::drop_list_duplicates
. It is replaced by the new APIcudf::list::distinct
which has a simpler implementation but better performance. The replacements for internal cudf usage have all been merged before thus there is no side effect or breaking for the existing APIs in this work.Closes #11114, #11093, #11053, #11034, and closes #9257.
Depends on:
collect_set
to usecudf::distinct
andcudf::lists::distinct
#11228lists::distinct
andcudf::detail::stable_distinct
#11149cudf::lists::distinct
in Python binding #11234cudf::lists::distinct
in Java binding #11233