Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory_usage() for ListSeries #11355

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Jul 26, 2022

Description

This PR fixes the memory_usage() call for ListSeries. This is a bugfix. https://www.github.com/rapidsai/cuspatial/pull/585 depends on this. Perhaps it can get into branch-22.08?

Fixes #11346.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@thomcom thomcom requested a review from a team as a code owner July 26, 2022 17:20
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 26, 2022
@thomcom thomcom added bug Something isn't working 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Jul 26, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 26, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@8faf2b0). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11355   +/-   ##
===============================================
  Coverage                ?   86.39%           
===============================================
  Files                   ?      143           
  Lines                   ?    22746           
  Branches                ?        0           
===============================================
  Hits                    ?    19651           
  Misses                  ?     3095           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8faf2b0...4462cd1. Read the comment docs.

@thomcom
Copy link
Contributor Author

thomcom commented Jul 26, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e7e5f45 into rapidsai:branch-22.08 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ListColumn.memory_usage() doesn't work when the list has more than one nested item in it.
3 participants