Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Added Java bindings for Parquet options for binary read #11410

Merged
merged 6 commits into from
Aug 3, 2022

Conversation

razajafri
Copy link
Contributor

@razajafri razajafri commented Jul 30, 2022

Description

This PR adds Java bindings for adding binary option for ParquetOptions

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@razajafri razajafri requested a review from a team as a code owner July 30, 2022 02:26
@github-actions github-actions bot added the Java Affects Java cuDF API. label Jul 30, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@03f1c1c). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11410   +/-   ##
===============================================
  Coverage                ?   86.47%           
===============================================
  Files                   ?      144           
  Lines                   ?    22856           
  Branches                ?        0           
===============================================
  Hits                    ?    19765           
  Misses                  ?     3091           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f1c1c...8c0ea07. Read the comment docs.

Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this functionality was added to the base ColumnFilterOptions class instead of ParquetOptions? I think we are only adding this for parquet?

@razajafri
Copy link
Contributor Author

Is there a reason this functionality was added to the base ColumnFilterOptions class instead of ParquetOptions? I think we are only adding this for parquet?

The reason I did it in ColumnFilter was to avoid the code duplication of having to create all the methods from the Builder. But I do see this as a problem.

@razajafri razajafri added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 2, 2022
@razajafri
Copy link
Contributor Author

rerun tests

@razajafri
Copy link
Contributor Author

@jbrennan333 I think I have addressed your concerns PTAL

Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @razajafri!
This looks good to me.

Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c++ looks good!

@razajafri
Copy link
Contributor Author

@bdice can we merge this?

@jjacobelli jjacobelli merged commit dcae9f7 into rapidsai:branch-22.08 Aug 3, 2022
@razajafri razajafri deleted the parquet_read_binary branch August 3, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants