Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Relax arrow version in dev env #11418

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

Arrow version pinnings were relaxed in this commit: d740c3c, this PR performs the same change in dev env.

Checklist

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 1, 2022
@galipremsagar galipremsagar self-assigned this Aug 1, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner August 1, 2022 19:09
@github-actions github-actions bot added the conda label Aug 1, 2022
@galipremsagar galipremsagar added the improvement Improvement / enhancement to an existing function label Aug 1, 2022
@jakirkham
Copy link
Member

Should we update this too?

arrow_cpp_version:
- "=8"

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Aug 1, 2022

Should we update this too?

arrow_cpp_version:
- "=8"

That was already updated in d740c3c, no?

@jakirkham
Copy link
Member

Normally we drop the =s, but that should be fine

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@d740c3c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 150cdbc differs from pull request most recent head 3b2ece2. Consider uploading reports for the commit 3b2ece2 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #11418   +/-   ##
===============================================
  Coverage                ?   86.47%           
===============================================
  Files                   ?      144           
  Lines                   ?    22856           
  Branches                ?        0           
===============================================
  Hits                    ?    19765           
  Misses                  ?     3091           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d740c3c...3b2ece2. Read the comment docs.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 1, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 024642a into rapidsai:branch-22.08 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants