Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Update parquet fuzz tests to drop support for skiprows & num_rows #11505

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

In a previous PR #11480, skiprows & num_rows were removed from cudf.read_parquet, this PR updates the corresponding parquet reader fuzz tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Aug 10, 2022
@galipremsagar galipremsagar self-assigned this Aug 10, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner August 10, 2022 14:40
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@11d40a0). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c69e2ea differs from pull request most recent head d20f848. Consider uploading reports for the commit d20f848 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.10   #11505   +/-   ##
===============================================
  Coverage                ?   86.48%           
===============================================
  Files                   ?      144           
  Lines                   ?    22850           
  Branches                ?        0           
===============================================
  Hits                    ?    19761           
  Misses                  ?     3089           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Aug 10, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 80a2f2b into rapidsai:branch-22.10 Aug 10, 2022
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond 5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants