Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert removal of skip_rows / num_rows options from the Parquet reader. #11657

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Revert removal of skip_rows / num_rows options from the Parquet reader. #11657

merged 2 commits into from
Sep 8, 2022

Conversation

nvdbaranec
Copy link
Contributor

@nvdbaranec nvdbaranec commented Sep 6, 2022 •
edited
Loading

Reverts:

#11480
#11503

@nvdbaranec nvdbaranec added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 6, 2022
@nvdbaranec nvdbaranec requested review from a team as code owners September 6, 2022 19:46
@nvdbaranec nvdbaranec added libcudf Affects libcudf (C++/CUDA) code. cuIO cuIO issue and removed libcudf Affects libcudf (C++/CUDA) code. labels Sep 6, 2022
@nvdbaranec nvdbaranec added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 6, 2022
@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@1742a4d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.10   #11657   +/-   ##
===============================================
  Coverage                ?   86.41%           
===============================================
  Files                   ?      145           
  Lines                   ?    22998           
  Branches                ?        0           
===============================================
  Hits                    ?    19874           
  Misses                  ?     3124           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

PointKernel
PointKernel requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parquet_reader.cpp benchmark file has been refactored/removed in a recent PR (#11611). @nvdbaranec Can you please remove the file accordingly?

cpp/benchmarks/io/parquet/parquet_reader.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Python Affects Python cuDF API. label Sep 7, 2022
PointKernel
PointKernel approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@PointKernel
Copy link
Member

Should I reopen #9970 with this PR being merged?

@nvdbaranec
Copy link
Contributor Author

Should I reopen #9970 with this PR being merged?

Do we know if that issue is still happening? I thought it had gotten fixed but maybe I'm misremembering.

@upsj upsj removed their request for review September 7, 2022 20:33
@nvdbaranec nvdbaranec removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Sep 8, 2022
@nvdbaranec
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 37612ee into rapidsai:branch-22.10 Sep 8, 2022
@galipremsagar galipremsagar mentioned this pull request Nov 16, 2023
Merged
3 tasks
@GregoryKimball GregoryKimball mentioned this pull request Feb 26, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@shwina shwina Awaiting requested review from shwina shwina was automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca was automatically assigned from rapidsai/cudf-python-codeowners

@cwharris cwharris Awaiting requested review from cwharris cwharris is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nvdbaranec @PointKernel @ttnghia