Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all libcudf APIs run on cudf's default stream #11759

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 23, 2022

Description

This PR corrects a couple of places where we are running on the CUDA default stream instead of cudf's default stream.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Sep 23, 2022
@vyasr vyasr self-assigned this Sep 23, 2022
@vyasr vyasr requested a review from a team as a code owner September 23, 2022 22:25
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@204a09c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11759   +/-   ##
===============================================
  Coverage                ?   87.52%           
===============================================
  Files                   ?      133           
  Lines                   ?    21774           
  Branches                ?        0           
===============================================
  Hits                    ?    19057           
  Misses                  ?     2717           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cpp/src/dictionary/search.cu Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Sep 26, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cd60462 into rapidsai:branch-22.10 Sep 26, 2022
@vyasr vyasr deleted the fix/thrust_device_policy branch January 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants