Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add doc section for list & struct handling #11770

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Sep 26, 2022

Description

Fixes: #11011

This PR:

  • Adds a side-section for list & struct handling.
  • Reduces duplication.
  • Exposes more ListMethods APIs.

Checklist

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@cd60462). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11770   +/-   ##
===============================================
  Coverage                ?   87.52%           
===============================================
  Files                   ?      133           
  Lines                   ?    21774           
  Branches                ?        0           
===============================================
  Hits                    ?    19058           
  Misses                  ?     2716           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar requested review from shwina and removed request for bdice September 26, 2022 21:57
@shwina
Copy link
Contributor

shwina commented Sep 26, 2022

Nice! This was sorely needed.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuDF (Python) Reviewer labels Sep 26, 2022
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a945377 into rapidsai:branch-22.10 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add Doc section for list methods
2 participants