Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix strings_udf_version version in 22.12 #11771

Closed
wants to merge 3 commits into from
Closed

[REVIEW] Fix strings_udf_version version in 22.12 #11771

wants to merge 3 commits into from

Conversation

galipremsagar
Copy link
Contributor

Description

This PR fixes a missed version upgrade in cmake file.

Checklist

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Sep 26, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner September 26, 2022 19:34
@galipremsagar galipremsagar self-assigned this Sep 26, 2022
@github-actions github-actions bot added CMake CMake build issue Python Affects Python cuDF API. labels Sep 26, 2022
@galipremsagar galipremsagar mentioned this pull request Sep 26, 2022
Merged
1 task
@galipremsagar galipremsagar changed the title [REVIEW] Fix string_udf_version version in 22.12 [REVIEW] Fix strings_udf_version version in 22.12 Sep 26, 2022
rapids-bot bot pushed a commit that referenced this pull request Sep 26, 2022
@galipremsagar
Update strings udf version updater script (#11772)
7a35ed9 
This PR updates the version updater script so that we don't have to manually upgrade the strings_udf version in cmake file here: #11771

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #11772
@github-actions github-actions bot added gpuCI libcudf Affects libcudf (C++/CUDA) code. labels Sep 27, 2022
@galipremsagar galipremsagar requested review from a team as code owners September 27, 2022 09:42
@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. gpuCI labels Sep 27, 2022
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 28, 2022
@galipremsagar
Copy link
Contributor Author

closing because #11801 contains the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@raydouglass raydouglass raydouglass approved these changes

@davidwendt davidwendt davidwendt approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CMake CMake build issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galipremsagar @robertmaynard @raydouglass @davidwendt