Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile warning from CUDF_FUNC_RANGE in a member function #11798

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Sep 27, 2022

Description

Compile warning was introduced in #11652 in bgzip_data_chunk_source.cu. The warning can be seen here https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/12417/consoleFull (search for 177-D)

/cudf/cpp/src/io/text/bgzip_data_chunk_source.cu(362): warning #177-D: variable "nvtx3_range__" was declared but never referenced

The nvtx3_range__ is part of the CUDF_FUNC_RANGE() macro. The warning is incorrect and likely a compiler bug. The workaround in this PR is to add [[maybe_unused]] to the variable declaration.

I was not able to create a small reproducer for compile bug filing.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 27, 2022
@davidwendt davidwendt requested a review from a team as a code owner September 27, 2022 21:35
@davidwendt davidwendt self-assigned this Sep 27, 2022
Copy link
Contributor

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I wasn't familiar enough with C++ attributes to do it myself ;)

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 87.40% // Head: 87.52% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (3fa0e50) compared to base (f72c4ce).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11798      +/-   ##
================================================
+ Coverage         87.40%   87.52%   +0.11%     
================================================
  Files               133      133              
  Lines             21833    21801      -32     
================================================
- Hits              19084    19081       -3     
+ Misses             2749     2720      -29     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 93.29% <0.00%> (+2.11%) ⬆️
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <0.00%> (+4.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ec4cdd8 into rapidsai:branch-22.12 Sep 29, 2022
@davidwendt davidwendt deleted the warning-nvtx3-range-var branch September 29, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants