Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gpuCI] Forward-merge branch-22.10 to branch-22.12 [skip gpuci] #11821

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

GPUtester
Copy link
Collaborator

Forward-merge triggered by push to branch-22.10 that creates a PR to keep branch-22.12 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

We need to actually call the method otherwise we will get false positives for validity of the operands.

Fortunately, this seems to have been a benign bug since the host pandas `NAType` handles all of 
the operations appropriately, so the code was "working" before, but the logic was incorrect.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Bradley Dice (https://github.com/bdice)

URL: #11818
@GPUtester GPUtester requested a review from a team as a code owner September 29, 2022 15:42
@GPUtester GPUtester merged commit 87d0387 into branch-22.12 Sep 29, 2022
@GPUtester
Copy link
Collaborator Author

SUCCESS - forward-merge complete.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants