Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RangeIndex unary operators. #11868

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 5, 2022

Description

These operators rely on a method that was renamed in #11272 and are also out of sync with the rest of the RangeIndex design now that the __getattr__ overload has been removed (#10538).

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Oct 5, 2022
@vyasr vyasr self-assigned this Oct 5, 2022
@vyasr vyasr requested a review from a team as a code owner October 5, 2022 23:24
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 87.40% // Head: 87.49% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (dfb4b91) compared to base (f72c4ce).
Patch coverage: 79.54% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11868      +/-   ##
================================================
+ Coverage         87.40%   87.49%   +0.08%     
================================================
  Files               133      133              
  Lines             21833    21830       -3     
================================================
+ Hits              19084    19101      +17     
+ Misses             2749     2729      -20     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/index.py 92.39% <50.00%> (-0.25%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/scalar.py 90.52% <100.00%> (+1.25%) ⬆️
python/dask_cudf/dask_cudf/sorting.py 93.29% <100.00%> (+2.11%) ⬆️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 6, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 029b1db into rapidsai:branch-22.12 Oct 6, 2022
@vyasr vyasr deleted the fix/rangeindex_unaops branch January 23, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants