Fixes Unsupported column type error due to empty list columns in Nested JSON reader #11897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable empty input test in nested json reader
karthikeyann
added
bug
karthikeyann
requested review from
mroeschke,
charlesbluca,
vyasr and
hyperbolic2346
Codecov ReportBase: 87.40% // Head: 88.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11897 +/- ##
================================================
+ Coverage 87.40% 88.11% +0.70%
================================================
Files 133 133
Lines 21833 21881 +48
================================================
+ Hits 19084 19281 +197
+ Misses 2749 2600 -149
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hyperbolic2346
approved these changes
Oct 12, 2022
vyasr
approved these changes
Oct 12, 2022
cpp/src/io/json/json_column.cu
Outdated
| @@ -689,19 +689,24 @@ std::pair<std::unique_ptr<column>, std::vector<column_name_info>> device_json_co | |||
| size_type num_rows = json_col.child_offsets.size() - 1; | |||
| std::vector<column_name_info> column_names{}; | |||
| column_names.emplace_back("offsets"); | |||
| column_names.emplace_back(json_col.child_columns.begin()->first); | |||
| column_names.emplace_back( | |||
| json_col.child_columns.empty() ? "element" : json_col.child_columns.begin()->first); | |||
There was a problem hiding this comment.
I'm guessing this name is only ever seen internally, so it probably doesn't matter much, but I would still prefer using some extremely obvious placeholder name.
There was a problem hiding this comment.
moving list_child_name as global constexpr.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
Unsupported column typeerror during cudf column creation in Nested JSON reader due to empty list column.During json tree creation, Empty list column does not have
device_json_columnchild because it does have any rows, or a type.This PR fixes the issue by creating an empty column as element child column. The list column still retains the null, and empty list information.
Checklist