[skip gpuci] Replace default_stream_value with get_default_stream in docs. #11985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
PointKernel
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
I was wondering why get_default_stream is preferred over default_stream_value since the latter is also public in my mind (and now I see why!). There are a lot of stream-related changes going on during my leave and I need to catch up.
Thanks for the work!
LGTM
upsj
approved these changes
Oct 25, 2022
ttnghia
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brings the docs in line with the new way of getting the default stream in libcudf.
Checklist