Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inplace arithmetic operators to MaskedType #11987

Conversation

brandon-b-miller
Copy link
Contributor

Closes #11887

After merging, we will support syntax like a += b inside UDFs used through DataFrame.apply and Series.apply.

@brandon-b-miller brandon-b-miller added feature request New feature or request 3 - Ready for Review Ready for review by team numba Numba issue Python Affects Python cuDF API. non-breaking Non-breaking change labels Oct 25, 2022
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner October 25, 2022 16:24
@brandon-b-miller brandon-b-miller self-assigned this Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 87.40% // Head: 88.14% // Increases project coverage by +0.73% 🎉

Coverage data is based on head (896a092) compared to base (f72c4ce).
Patch has no changes to coverable lines.

❗ Current head 896a092 differs from pull request most recent head 3e898b4. Consider uploading reports for the commit 3e898b4 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11987      +/-   ##
================================================
+ Coverage         87.40%   88.14%   +0.73%     
================================================
  Files               133      133              
  Lines             21833    21995     +162     
================================================
+ Hits              19084    19388     +304     
+ Misses             2749     2607     -142     
Impacted Files Coverage Δ
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (-12.57%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 82.20% <0.00%> (-3.35%) ⬇️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.92% <0.00%> (-0.21%) ⬇️
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) ⬇️
python/cudf/cudf/__init__.py 90.69% <0.00%> (ø)
python/cudf/cudf/core/udf/_ops.py 100.00% <0.00%> (ø)
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brandon-b-miller brandon-b-miller added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 26, 2022
@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b89c0e2 into rapidsai:branch-22.12 Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change numba Numba issue Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA] Support arithmetic assignment operators (e.g. "+=") in UDFs
2 participants