Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force black exclusions for pre-commit. #12036

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 1, 2022

Description

This PR fixes an issue where black would not respect the exclusions in pyproject.toml when run via pre-commit. When executing the hook, pre-commit explicitly lists all changed files and provides them as positional arguments to black. When black receives explicit filenames, it does not respect the exclude settings but does respect the force-exclude settings added in black 20.8b1. See issue: psf/black#438 and PR: psf/black#1032.

cc: @csadorf for cuML

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice self-assigned this Nov 1, 2022
@bdice bdice added bug Something isn't working code quality non-breaking Non-breaking change and removed code quality labels Nov 1, 2022
@bdice bdice marked this pull request as ready for review November 1, 2022 14:16
@bdice bdice requested review from vyasr and a team November 1, 2022 14:17
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 87.40% // Head: 88.12% // Increases project coverage by +0.71% 🎉

Coverage data is based on head (5a317fe) compared to base (f72c4ce).
Patch has no changes to coverable lines.

❗ Current head 5a317fe differs from pull request most recent head 1ea4538. Consider uploading reports for the commit 1ea4538 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12036      +/-   ##
================================================
+ Coverage         87.40%   88.12%   +0.71%     
================================================
  Files               133      133              
  Lines             21833    21982     +149     
================================================
+ Hits              19084    19372     +288     
+ Misses             2749     2610     -139     
Impacted Files Coverage Δ
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (-12.57%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/cudf/cudf/core/dataframe.py 93.67% <0.00%> (-0.10%) ⬇️
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@msadang msadang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msadang msadang merged commit 80c238c into rapidsai:branch-22.12 Nov 1, 2022
@benfred benfred mentioned this pull request Nov 9, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants