Allow falling back to shim_60.ptx by default in strings_udf
#12056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
bug
galipremsagar
approved these changes
Nov 3, 2022
vyasr
approved these changes
Nov 3, 2022
|
rerun tests |
Codecov ReportBase: 88.06% // Head: 88.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12056 +/- ##
================================================
+ Coverage 88.06% 88.09% +0.03%
================================================
Files 135 135
Lines 21984 21997 +13
================================================
+ Hits 19360 19379 +19
+ Misses 2624 2618 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of distributed,
strings_udfneeds to import and set itself up without creating a CUDA context, as this can interfere with up the way the network is being set up. In this situation it can't use it's normal mechanism (which requires a context) to query the compute capability of the device, and it falls back on an environment variableSTRINGS_UDF_CCthat it needs to be passed from dask instead. A user can set this and their code will work no problem, but we also need some default configuration that just works when someone builds their code. Without knowing their setup beforehand this can be problematic, as such I originally added the default value ofcc=52when the environment variable isn't set. This was however not exactly correct for a few reasons:This PR fixes this problem.