Throw an error when libcudf is built without cuFile and LIBCUDF_CUFILE_POLICY is set to "ALWAYS"
#12080
Conversation
vuule
added
cuIO
Codecov ReportBase: 87.47% // Head: 88.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12080 +/- ##
================================================
+ Coverage 87.47% 88.04% +0.56%
================================================
Files 133 135 +2
Lines 21826 22025 +199
================================================
+ Hits 19093 19392 +299
+ Misses 2733 2633 -100
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -269,6 +269,10 @@ std::unique_ptr<cufile_input_impl> make_cufile_input(std::string const& filepath | |||
| if (cufile_integration::is_always_enabled()) throw; | |||
| } | |||
| } | |||
| #else | |||
There was a problem hiding this comment.
Is the try-catch still required?
Perhaps whatever is thrown in std::make_unique<cufile_input_impl>(filepath) should just pass through to the caller.
There was a problem hiding this comment.
try-catch is still required because we want to silently fall back to host path if GDS fails and LIBCUDF_CUFILE_POLICY!="ALWAYS" Returning a null is not an error here. We fall back to a different source/sink type.
There was a problem hiding this comment.
Refactored the PR inspired by your question, less branching now :)
|
build |
|
@gpucibot merge |
Description
Currently, creating a cufile
datasourceordata_sinksilently fails if libcudf was built without the cuFile headers. This is expected behavior when theLIBCUDF_CUFILE_POLICYis not set, or is set to and value other than "ALWAYS". However, with "ALWAYS", there should be no fallback from GDS.This PR adds a check to fail loudly when
LIBCUDF_CUFILE_POLICY=="ALWAYS"cannot be enforced because of missing dependency (cuFile).Checklist