Refactor purge_nonempty_nulls
#12111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
3 - Ready for Review
ttnghia
commented
Nov 9, 2022
| @@ -80,6 +80,24 @@ bool has_nonempty_nulls(cudf::column_view const& input, rmm::cuda_stream_view st | |||
|
|
|||
| return false; | |||
| } | |||
|
|
|||
| std::unique_ptr<column> purge_nonempty_nulls(column_view const& input, | |||
There was a problem hiding this comment.
This is moved from the deleted file copy.cuh.
|
Rerun tests. |
bdice
approved these changes
Nov 15, 2022
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
Rerun tests. |
|
Rerun tests. |
Codecov ReportBase: 87.47% // Head: 88.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12111 +/- ##
================================================
+ Coverage 87.47% 88.15% +0.67%
================================================
Files 133 135 +2
Lines 21826 22144 +318
================================================
+ Hits 19093 19520 +427
+ Misses 2733 2624 -109
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@gpucibot merge |
ajschmidt8
approved these changes
Nov 16, 2022
raydouglass
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor combines the discrete interfaces of
purge_nonempty_nullsthat requirestructs/strings/lists_column_viewinput into just one interface accepting justcolumn_view. This facilitates easier usage of this function. It is also a necessary step for subsequent work in fixingstructs::superimpose_parent_nulls.cudf::detailinterface for this new API is also added.